Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[story ads] Introduce new progress bar #33972

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

calebcordry
Copy link
Member

@calebcordry calebcordry commented Apr 23, 2021

To be enabled when ads are auto advancing. Should help user confusion.

image

@calebcordry calebcordry requested review from lannka and powerivq April 23, 2021 15:22
@calebcordry calebcordry marked this pull request as ready for review April 23, 2021 15:22
@amp-owners-bot amp-owners-bot bot requested a review from rileyajones April 23, 2021 15:22
@calebcordry
Copy link
Member Author

Partial #33969

@calebcordry calebcordry merged commit 583a733 into ampproject:main Apr 23, 2021
@calebcordry calebcordry deleted the progress-bar branch April 23, 2021 18:17
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants