Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externs: remove two outdated files #33963

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Externs: remove two outdated files #33963

merged 1 commit into from
Apr 22, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Apr 22, 2021 •
edited
Loading

summary

  • multi-pass is dead
  • WeakRef has been added to the es6.js extern file within closure

@samouri samouri requested review from jridgewell and rcebulko April 22, 2021 18:44
@samouri samouri self-assigned this Apr 22, 2021
@samouri samouri changed the title Externs: remove two outdated ones Externs: remove two outdated files Apr 22, 2021
@samouri samouri merged commit e5c57a6 into ampproject:main Apr 22, 2021
@samouri samouri deleted the rmextern branch April 22, 2021 20:21
@jridgewell jridgewell mentioned this pull request May 13, 2021
Merged
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@samouri @rochapablo
Externs: remove two outdated ones (ampproject#33963)
6d248c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@rcebulko rcebulko rcebulko approved these changes

Assignees

@samouri samouri

Labels
PR use: In Beta / Experimental PR use: In Stable Type: Refactoring WG: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samouri @jridgewell @rcebulko @ampprojectbot