✨ [Story Video] Connect CacheUrl service to amp-video and load sources #33466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 678d3b3 into 66ad8b8 - view on LGTM.com new alerts:
|
gmajoulet
reviewed
Apr 19, 2021
rcebulko
reviewed
Apr 19, 2021
Co-authored-by: Ryan Cebulko <ryan@cebulko.com>
gmajoulet
reviewed
Apr 20, 2021
mszylkowski
commented
Apr 20, 2021
There was a problem hiding this comment.
@gmajoulet fixed the tests according to your comments. PTAL
gmajoulet
approved these changes
Apr 21, 2021
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
ampproject#33466) * Added canonical to videos example * Started video cache * Use cdn url from url-impl * Remove unnecessary | null * Undo videos.html * Remove console.log * Using ternary operator for reduce * Account for cached docs * Update logic with toolbox * Added service * Undo amp-video * Added cache url service * Added owners * Cache url to video * Simplified cache example * Updated title * Changed name to amp-cache-url of folder * Update readme * Update comments * Remove example * Updated readme * Added code * Fixed tests * Removed comment * Added some more tests * Fixed cdnurl * Update names of docSupports * Fix cacheUrl not replacing * updated cacheDomain param name * Check not cached doc to add cache sources * improved implementation from comments * added tests * Added gregable file on examples * Added warning * Uppercase user error * Updated opt in * Fix response.json is promise * Updated test * Fixed toArray import * Fixed visibilityState * Use helper functions * Added tests to amp-cache-url * Update extensions/amp-cache-url/0.1/test/test-amp-cache-url.js Co-authored-by: Ryan Cebulko <ryan@cebulko.com> * Using extensionScriptInNode with win * Updated tests to match comments * Not export applySources Co-authored-by: Gabriel Majoulet <gmajoulet@google.com> Co-authored-by: Ryan Cebulko <ryan@cebulko.com> Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches the
/mbvvideo sources from the CDN cache and populates the sources with the result.Working DOM structure:
