Disable parent scrolling and swiping in lightbox #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO(dvoytenko): configure how to close. Or maybe leave it completely | ||
| // up to "on" element. | ||
| this.element.addEventListener('click', () => this.close()); | ||
| gestures.onGesture(TapRecognizer, () => this.close()); | ||
| gestures.onGesture(SwipeXYRecognizer, () => { |
There was a problem hiding this comment.
just for my knowledge purposes. how does adding an empty subscriber block the scroll and side-swipe events?
thanks.
There was a problem hiding this comment.
Gestures are exclusive. I.e. you can have a "tap" and a "swipe" at the same time. It's very different from events which fire all at the same time and can overlap. Once you say "I recognize swipeX", no other conflicting gesture will be allowed which is what we want here. In a way you can consider scroll and side-swipe as other gestures. Practically, once gesture is recognized it consumes all of the pointer events by stopping propagation and preventing default.
|
other than my question. LGTM |
dvoytenko
added a commit
that referenced
this pull request
Sep 29, 2015
Disable parent scrolling and swiping in lightbox
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332.
Closes #74.