Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗🚮 Remove unused packages #29990

Merged
merged 1 commit into from
Aug 27, 2020
Merged

🏗🚮 Remove unused packages #29990

merged 1 commit into from
Aug 27, 2020

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 26, 2020 •
edited
Loading

Package PR that removed the need for it
babel-plugin-transform-es2015-modules-commonjs #28747
regexp.escape #26779
require-hijack #29099
topological-sort #28747

Given the variety of ways in which amphtml uses its devDependencies, I haven't found a reliable way of automatically flagging unused packages.

@rsimha rsimha requested a review from kristoferbaxter August 26, 2020 17:56
@rsimha rsimha self-assigned this Aug 26, 2020
@google-cla google-cla bot added the cla: yes label Aug 26, 2020
@rsimha rsimha requested a review from rcebulko August 27, 2020 19:08
@rsimha rsimha merged commit 3549516 into ampproject:master Aug 27, 2020
@rsimha rsimha deleted the 2020-08-26-RemoveUnusedPackages branch August 27, 2020 21:48
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@rsimha @ed-bird
🏗🚮 Remove unused packages (ampproject#29990)
1b8784b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

@kristoferbaxter kristoferbaxter Awaiting requested review from kristoferbaxter

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsimha @rcebulko @ampprojectbot