-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗🚀 Speed up pre-closure babel
transforms
#27426
🏗🚀 Speed up pre-closure babel
transforms
#27426
Conversation
@erwinmombay @kristoferbaxter Extensively tested this locally, and it's now ready for a review. This will pave the way for minified lazy builds, and the pattern could potentially be adopted for targeted integration tests ( |
Awesome PR. Thank you for speeding up builds! ⭐️ |
@@ -308,10 +306,17 @@ exports.getGraph = function(entryModules, config) { | |||
}); | |||
|
|||
config.babel = config.babel || {}; | |||
const babelPlugins = conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we prioritize #27161? We're adding more and more call-site configurations that will make it difficult to synchronize changes across environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @rcebulko is already working on this. (A fair bit has changed in recent days, so that PR will need a full rebase before proceeding. Shouldn't be bad though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/will do 👍
Background:
gulp dist
) and type checker (gulp check-types
) run a set ofbabel
transforms on source files before invoking closure compiler.--core_runtime_only
and--noextensions
, which only compile a small subset of source files.This PR does the following:
gulp.src
streambuild-system/compile/pre-closure-babel.js
transferSrcsToTempDir()
and all associated codePerformance improvements (Macbook Pro):
gulp dist --core_runtime_only
gulp check-types
gulp dist --extensions_from examples/article.amp.html
gulp dist
gulp dist --single_pass
Coming up:
gulp
with instant startup and lazy building (🏗✨ Enable lazy-build and watch modes for minified code #27471)Addresses #26779 (comment)