Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-app-banner: Support apple-itunes-app lookup in AmpDocShadow #27346

Merged
merged 1 commit into from
Mar 27, 2020
Merged

amp-app-banner: Support apple-itunes-app lookup in AmpDocShadow #27346

merged 1 commit into from
Mar 27, 2020

Conversation

mdmower
Copy link
Contributor

@mdmower mdmower commented Mar 22, 2020

Query meta[name="apple-itunes-app"] using method supported by
AmpDocShadow as well as other AmpDoc subtypes.

@amp-owners-bot amp-owners-bot bot requested a review from alanorozco March 22, 2020 03:07
@mdmower mdmower mentioned this pull request Mar 22, 2020
Closed
33 tasks
alanorozco
alanorozco approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

Are there other cases for meta[name] lookups that would make sense to change to use this API?

@alanorozco alanorozco merged commit 292d825 into ampproject:master Mar 27, 2020
@mdmower
Copy link
Contributor Author

mdmower commented Mar 27, 2020

Thanks for doing this.

Are there other cases for meta[name] lookups that would make sense to change to use this API?

See #26652 . It's nearly complete.

@mdmower mdmower deleted the pr-appbanner branch March 27, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdmower @alanorozco @googlebot @ampprojectbot