Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Force bust cached document for amp-addthis #26761

Merged
merged 8 commits into from
Feb 12, 2020

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Feb 12, 2020

Adds ?_amp_=VERSION query param to force-bust old, broken versions of document when cached (origin has overly long cache age of 999 days, workaround for #24848)

@taojing10
@dmvjs
@pjcunnin
@matthinegardner

max-age should be changed on server :)

Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dmvjs dmvjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've brought this max-age up to be changed as well

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants