Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Change const to let VariableDeclarations for ESM Output #26727

Merged
merged 20 commits into from
Feb 11, 2020
Merged

🚀 Change const to let VariableDeclarations for ESM Output #26727

merged 20 commits into from
Feb 11, 2020

Conversation

kristoferbaxter
Copy link
Contributor

Has no impact on ES5 output, but un-compressed ESM output drops by ~1% for v0.

@kristoferbaxter
Move from media 'not-blocking' to 'print'
cfc797f
@kristoferbaxter
latest master
7c9902e
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
e1eb02c
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
3a5465a
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
870b22f
@kristoferbaxter
font stylesheet changes
e81a2d1
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
e073300
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
03935f4
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
1c78f0d
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
ce266db
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
2073a5b
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
78062ac
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
09127e7
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
a24ae5c
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
9a10297
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
100832e
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
420e0e6
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
97c2032
@kristoferbaxter
Merge branch 'master' of github.com:ampproject/amphtml
e03d86f
@kristoferbaxter
Babel plugin for const -> let
3102f39
@amp-owners-bot
Copy link

Hey @erwinmombay, these files were changed:

  • build-system/babel-plugins/babel-plugin-const-transformer/index.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/index.js

Hey @jridgewell, these files were changed:

  • build-system/babel-plugins/babel-plugin-const-transformer/index.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-let/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/ignored-var/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/input.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/options.json
  • build-system/babel-plugins/babel-plugin-const-transformer/test/fixtures/transform-assertions/should-transform/output.js
  • build-system/babel-plugins/babel-plugin-const-transformer/test/index.js

@kristoferbaxter kristoferbaxter merged commit b245bc2 into ampproject:master Feb 11, 2020
@kristoferbaxter kristoferbaxter deleted the let-const branch February 11, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristoferbaxter @erwinmombay @googlebot @ampprojectbot