Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🖍 [amp-story-player] Extract iframe css to different file #26613

Merged
merged 3 commits into from
Feb 4, 2020
Merged

🖍 [amp-story-player] Extract iframe css to different file #26613

merged 3 commits into from
Feb 4, 2020

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Feb 4, 2020

Partial for #24539 #26308

@Enriqe Enriqe mentioned this pull request Feb 4, 2020
Merged
gmajoulet
gmajoulet approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment on the name of the CSS output file

build-system/tasks/css.js Show resolved Hide resolved
alanorozco
alanorozco approved these changes Feb 4, 2020
View reviewed changes
css/OWNERS Outdated Show resolved Hide resolved
danielrozenberg
danielrozenberg approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for build-system/ change

@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 4, 2020

Thanks all!

@Enriqe Enriqe merged commit bb4fcac into ampproject:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

@newmuis newmuis newmuis approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Enriqe @alanorozco @gmajoulet @newmuis @danielrozenberg @googlebot @ampprojectbot