Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨<amp-next-page> v2 default and templated footers (more articles box) #26610

Merged
merged 10 commits into from
Feb 11, 2020
Merged

✨<amp-next-page> v2 default and templated footers (more articles box) #26610

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
88bb689
Implements default and templated footers
wassgha Feb 4, 2020
f6cdd00
Fixes type checking
wassgha Feb 4, 2020
7122fdb
Merge branch 'master' into amp-next-page-v2-footer
wassgha Feb 5, 2020
37e4257
Type checking fixes
wassgha Feb 5, 2020
b14e5ea
Merge branch 'master' into amp-next-page-v2-footer
wassgha Feb 6, 2020
67e61a3
Added tests
wassgha Feb 6, 2020
2860c2c
Simplifies separator and implements requested changes (1/2)
wassgha Feb 10, 2020
7086f71
Requested changes (2/2)
wassgha Feb 11, 2020
2889e54
Requested changes (2/2)
wassgha Feb 11, 2020
e452d7f
Fixes type check
wassgha Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes type check
  • Loading branch information
@wassgha
wassgha committed Feb 11, 2020
commit e452d7f19651f450181c49362262eff5a9d56d52
2 changes: 1 addition & 1 deletion extensions/amp-next-page/1.0/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export class NextPageService {
/** @private {?Element} */
this.footer_ = null;

/** @private {function(!Promise)} */
/** @private {function():!Promise} */
this.refreshFooter_ = ASYNC_NOOP;

/** @private {boolean} */
Expand Down