Enable text/javascript header type. #26465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Feb 4, 2020
|
@choumx for final review |
|
@adamsilverstein howdy, theres just a minor lint issue that needs to be fixed then I will merge this right away. Thanks! I believe you just need to run |
|
@erwinmombay thanks for the tip: applied and pushed. |
adamsilverstein
force-pushed
the
fix/26259
branch
from
d796744 to
8daf708
Compare
|
Trying a rebase to see if I can get what appears to be a flakey test to pass in Travis. |
adamsilverstein
force-pushed
the
fix/26259
branch
from
8daf708 to
21e951b
Compare
|
@erwinmombay This should be ready for re-review/merge. |
samouri
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug fix: Enable
text/javascriptcontent type for scripts loaded viaamp-script.Addresses #26259.