-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Rename ShadowDomWriter* => DomWriter* #26447
♻️Rename ShadowDomWriter* => DomWriter* #26447
Conversation
src/dom-writer.js
Outdated
@@ -0,0 +1,349 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this to utils/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done.
Looking into test failures, I can repro on clean master so I think something strange is going on. |
Test failures should be fixed by #26607 when merged 🤞 |
Rename classes and move to their own file in preparation for ads use-case. After reviewing again, I don't think we will need to change the impl (not really anything shadow specific) but if necessary will do in a follow up PR.