✨ Add 'feed' to allowed protocols for links #26362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ampproject/wg-caching, these files were changed:
|
honeybadgerdontcare
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
LGTM, this list usually stays closely align to amp-social-share. You may wish to add it there as well. https://github.com/ampproject/amphtml/blob/master/extensions/amp-social-share/validator-amp-social-share.protoascii#L35
|
@honeybadgerdontcare thanks. Would adding to |
|
@westonruter NSO, just pointing the relationship out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a WordPress theme that was using the
feedURI scheme. The WordPress AMP plugin removed the link because this protocol is not allowed. However, I believe it should be. Clicking suchfeedlinks on Mac OS results in the Apple News app being opened:Example: