Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ The Ozone Project: Add RTC endpoint to callout-vendors.js #26039

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

greg-silvermine
Copy link
Contributor

This PR adds The Ozone Project RTC callout URL in callout-vendors.js.

NOTE:
Our endpoint will be responding with content only to requests from the domains that are whitelisted in our prebid-server setup.

@mrjoro The Ozone Project agreed to the corporate CLA AFAIK but I am not sure what's the status of that at the moment.

@keithwrightbos Could you please review and let me know if anything else is required.

Thanks,
Greg

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@greg-silvermine
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@AskRupert-DM
Copy link

@keithwrightbos - are you able to approve this PR and merge it for us please ... if there's any details required to push this through please let us know.

@AskRupert-DM
Copy link

AskRupert-DM commented Jan 20, 2020

@rcebulko - do you think you can help us with this error - https://github.com/ampproject/amphtml/pull/26039/checks?check_run_id=398670458 - we've rebased from the master branch but still getting errors.

Likewise @keithwrightbos could you help with the owners approval please ?

@rcebulko
Copy link
Contributor

@rcebulko - do you think you can help us with this error - https://github.com/ampproject/amphtml/pull/26039/checks?check_run_id=398670458 - we've rebased from the master branch but still getting errors.

Sauce has been a bit flaky of late. I've just started looking into it, hopefully can get it resolved soon 👍

@AskRupert-DM
Copy link

AskRupert-DM commented Jan 23, 2020

hey @keithwrightbos - all the checks are now passing - would you please be able to approve/merge this PR in or provide a timeframe or alternatively @rsimha / @lannka / @gmajoulet could either of you assist with reviewing and approving this PR for me please ?

@lannka lannka merged commit d6ecf7c into ampproject:master Jan 23, 2020
@AskRupert-DM
Copy link

Thanks @lannka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants