Code

🐛 Fix amp-list race condition#25964

Code

Merged

dreamofabear merged 10 commits intoampproject:masterampproject/amphtml:masterfrom samouri:fix-amp-list-racesamouri/amphtml:fix-amp-list-raceCopy head branch name to clipboardJan 3, 2020

+53-2

Commits

Commits on Dec 10, 2019

• amp-list: bail out of rendering updates if the src has changed in the meantime

  samouri

  committed
  96ab4b3

  Copy full SHA for 96ab4b3

• Add test

  samouri

  committed
  0c29da4

  Copy full SHA for 0c29da4

• add test

  samouri

  committed
  16b4a1e

  Copy full SHA for 16b4a1e

• more specific test

  samouri

  committed
  f16e987

  Copy full SHA for f16e987

• remove only

  samouri

  committed
  b2c334e

  Copy full SHA for b2c334e

Commits on Dec 24, 2019

• no need to return promise (jridgewell)

  samouri

  committed
  b9131b9

  Copy full SHA for b9131b9

• cleaner test case with a more explicit wait

  samouri

  committed
  6cb6def

  Copy full SHA for 6cb6def

• remove Promise again

  samouri

  committed
  a269223

  Copy full SHA for a269223

• whitespace

  samouri

  committed
  9c6875b

  Copy full SHA for 9c6875b

• lint

  samouri

  committed
  82cdeed

  Copy full SHA for 82cdeed