Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Make macro-after-long-task the default for chunk.js #25797

Merged
merged 15 commits into from
Dec 3, 2019
Merged

🚀 Make macro-after-long-task the default for chunk.js #25797

merged 15 commits into from
Dec 3, 2019

Conversation

kristoferbaxter
Copy link
Contributor

Improve FID by breaking up work into macro tasks by default.

@dvoytenko
Copy link
Contributor

@kristoferbaxter How long has this been in PROD? Unfortunately, it's very hard to tell with URL opt-ins. Also, should we set it to 1 first for all cases, including direct origin?

@kristoferbaxter
Copy link
Contributor Author

This has been active at 100% of the canary/dev usage since August.

We could move to just setting the default value to 1 for prod as well, but the change to unwind is not substantially different (reverting the check in that sets the default to macro-after-long-task).

@kristoferbaxter kristoferbaxter merged commit 469485d into ampproject:master Dec 3, 2019
@kristoferbaxter kristoferbaxter deleted the remove-experiment branch December 3, 2019 01:56
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* Move from media 'not-blocking' to 'print'

* font stylesheet changes

* Make Macro after long task default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants