Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake FIE and amp-iframe tests executed on the running runtime #25727

Merged
merged 4 commits into from
Nov 23, 2019
Merged

Deflake FIE and amp-iframe tests executed on the running runtime #25727

merged 4 commits into from
Nov 23, 2019

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Nov 21, 2019 •
edited
Loading

Related to #9177, #22533, #23935.

@dvoytenko dvoytenko changed the title Testing master branch tests DO NOT SUBMIT: Testing master branch tests Nov 21, 2019
@dvoytenko dvoytenko changed the title DO NOT SUBMIT: Testing master branch tests Deflake FIE and amp-iframe tests executed on the running runtime Nov 22, 2019
@rsimha
Copy link
Contributor

rsimha commented Nov 22, 2019

When I checked out this branch and ran gulp unit --local_changes, I saw that only 9 tests were running, following which mocha appears to exit cleanly.

image

I looked at your test code and noticed that the test should deny http is calling expectAsyncConsoleError. I'm guessing the test isn't waiting on this async error, as a result of which it's leaking into afterEach.

Pretty sure you're hitting #15658, which is due to mochajs/mocha#94.

@dvoytenko
Copy link
Contributor Author

I looked at your test code and noticed that the test should deny http is calling expectAsyncConsoleError. I'm guessing the test isn't waiting on this async error, as a result of which it's leaking into afterEach.

It looks like I'm able to resolve this issue for this particular test suit, but I don't yet see a generic solution here. I have some ideas on this, but need to dig around more.

@dvoytenko dvoytenko merged commit 342f40c into ampproject:master Nov 23, 2019
@dvoytenko dvoytenko deleted the tests1 branch November 23, 2019 00:44
@dvoytenko dvoytenko mentioned this pull request Nov 26, 2019
Closed
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Deflake FIE and amp-iframe tests executed on the running runtime (amp…
a3e081b 
…project#25727)

* Testing master branch tests

* deflake

* Remove async errors

* lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoytenko @rsimha @googlebot