✅ Remove skipWindows() as a test config #24143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this adds 76 tests back to SauceLabs |
rsimha
approved these changes
Aug 22, 2019
|
Tests can opt into Safari, nothing for Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipWindows()was used to skip flaky tests, but introduced a side effect where tests were being skipped for all browsers (excluding those opted into Safari) in Sauce Labs. This is because we run integration tests for Chrome, Firefox, Edge and IE on Windows.Skipping tests should be allowed at the browser level, not OS.
related to #24124