Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Fix detection for failure to generateRunner #24084

Merged
merged 4 commits into from
Aug 21, 2019
Merged

🏗 Fix detection for failure to generateRunner #24084

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f4f5a7
Fix detection for failure to generateRunner; add link to Java install…
westonruter Aug 20, 2019
059ea4e
Improve messaging in case of runner.jar error
westonruter Aug 20, 2019
ed2ff58
Fix lint error
westonruter Aug 20, 2019
dbf4fdd
Add lando tooling for gulp lint
westonruter Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix detection for failure to generateRunner; add link to Java install… 
… docs
  • Loading branch information
@westonruter
westonruter committed Aug 20, 2019
commit 4f4f5a720f5b7321385346b372b2c64c3b1af8e2
10 changes: 8 additions & 2 deletions build-system/tasks/generate-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,19 @@ async function generateRunner(subDir) {
const runnerJarDir = `${runnerDistDir}/${subDir}`;
writeGeneratedAtCommitFile(runnerJarDir);
const result = getOutput(generateCmd);
if (result.stderr) {
if (0 !== result.status) {
log(
red('ERROR:'),
'Could not generate custom closure compiler',
cyan(`${runnerJarDir}/runner.jar`)
);
console.error(red(result.stdout), red(result.stderr));
console.error(
red(result.stdout),
red(result.stderr),
red(
'See instructions for setting up Java at https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#building-amp-and-starting-a-local-server'
)
rsimha marked this conversation as resolved.
Show resolved Hide resolved
);
const reason = new Error('Compiler generation failed');
reason.showStack = false;
return Promise.reject(reason);
Expand Down