Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update allowed form input elements #22725

Merged
merged 2 commits into from
Feb 12, 2020
Merged

📖 Update allowed form input elements #22725

merged 2 commits into from
Feb 12, 2020

Conversation

westonruter
Copy link
Member

Remove <input type=password> and <input type=file> from disallowed list, since they are now allowed.

See https://amp.dev/documentation/components/amp-form#inputs-and-fields

@westonruter westonruter mentioned this pull request Jun 6, 2019
Closed
@cvializ cvializ self-requested a review August 8, 2019 18:35
cvializ
cvializ approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch

@alanorozco alanorozco merged commit a09e1c9 into ampproject:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@cvializ cvializ cvializ approved these changes

@nainar nainar nainar approved these changes

@CrystalOnScript CrystalOnScript CrystalOnScript approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@westonruter @alanorozco @cvializ @nainar @CrystalOnScript @googlebot @ampprojectbot