Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Clean up .eslintignore #22411

Merged
merged 4 commits into from
May 21, 2019
Merged

🏗 Clean up .eslintignore #22411

merged 4 commits into from
May 21, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 21, 2019

With the adoption of prettier, we no longer need to exempt certain files / directories from linting. This PR removes unnecessary entries in .eslintignore and runs gulp lint --fix against those files.

The changes in e757d0b can be skimmed, while the rest can be reviewed normally.

Follow up to #21212

@rsimha rsimha requested a review from jridgewell May 21, 2019 15:35
@rsimha rsimha self-assigned this May 21, 2019
@rsimha rsimha requested a review from kristoferbaxter May 21, 2019 15:36
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item to verify, but looks good!

@rsimha rsimha merged commit 13dc93d into ampproject:master May 21, 2019
@rsimha rsimha deleted the 2019-05-21-CleanupEslintignore branch May 21, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants