Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅Skip date picker visual diff tests for flakes #20809

Merged
merged 1 commit into from
Feb 13, 2019
Merged

✅Skip date picker visual diff tests for flakes #20809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/visual-diff/visual-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,8 @@
"interactive_tests": "examples/visual-tests/amp-story/amp-story-page-attachment-desktop.js"
},
{
"flaky": true,
// See https://percy.io/ampproject/amphtml/builds/1434487/view/95137509/375?browser=firefox&mode=diff
"url": "examples/visual-tests/amp-date-picker/amp-date-picker.amp.html",
"name": "amp-date-picker",
"loading_complete_css": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other css element that can be added to this list, to indicate that the date picker is fully populated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I'll let you know what I find out 🤔

Expand Down