Page attachment call to action animation and design review. #20612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty cool! Do we want to restart the animation every time we visit the page containing the attachment? Playing with the demo I skipped the page, then came back and the animation was already over. Just thinking out loud, but otherwise it lgtm! |
newmuis
reviewed
Jan 31, 2019
| position: absolute !important; | ||
| top: 0 !important; | ||
| left: 0 !important; | ||
| height: 100% !important; | ||
| width: 100% !important; | ||
| background: #fff !important; | ||
| border-radius: 32px !important; | ||
| background: #FFF; |
gmajoulet
force-pushed
the
attachment_component_call_to_action_design_review
branch
from
db1be1c
to
ccb6b73
Compare
|
Good point, thanks! Hong said we should play the animation every time the page becomes active, I just made the change. PTAL |
Enriqe
approved these changes
Jan 31, 2019
newmuis
approved these changes
Jan 31, 2019
nbeloglazov
pushed a commit
to nbeloglazov/amphtml
that referenced
this pull request
Feb 12, 2019
…ct#20612) * Page attachment call to action animation and design review. * Restarting the animation every time the page becomes active.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…ct#20612) * Page attachment call to action animation and design review. * Restarting the animation every time the page becomes active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page attachment call to action animation and design review.
Demo on page two available until this PR is merged: here
#20209