✨Get placeholder background from placeholder srcs
#20563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
Jan 28, 2019
| if (element.hasAttribute(poster)) { | ||
| return element.getAttribute(poster); | ||
| } | ||
| const imgEl = element.querySelector( |
There was a problem hiding this comment.
Is img[placeholder] possible?
amp-img[placeholder], [placeholder] amp-img may cover more cases in case they wrap it in a div for some reason.
There was a problem hiding this comment.
Added [placeholder] amp-img.
There was a problem hiding this comment.
Lol, there used to be a TODO there to switch to amp-img, oh well. :)
| skipForSlot('uses `placeholder` img', () => { | ||
| const html = htmlFor(env.win.document); | ||
| const el = html`<amp-video> | ||
| <img src=foo.png placeholder> |
There was a problem hiding this comment.
ditto above, I didn't think this is valid.
There was a problem hiding this comment.
Not valid AMPHTML but generated by the runtime.
aghassemi
approved these changes
Jan 29, 2019
jsalgueiro
added a commit
to jsalgueiro/amphtml
that referenced
this pull request
Jan 29, 2019
* commit '273e1fe2ff7719bf555c9614afe19e14231e4dae': Changes to make carousel v2 work with lightbox gallery. (ampproject#20558) ✅ Additional carousel v2 end to end tests (ampproject#20522) ✨Get placeholder background from `placeholder` srcs (ampproject#20563) 🐛Reparent placeholder to account for incorrect positioning (ampproject#20562) Fix amp-sidebar keyboard event forwarding (ampproject#20557) 📖 Update `amp-video-docking` CSS reference (ampproject#20571) ✅Validate `dock` for `amp-youtube` (ampproject#20554) ✅Validate `dock` for `amp-brightcove` (ampproject#20567) ✅Add overflow prevention test (ampproject#20546) ✅Fix amp-date-display flakes (ampproject#20568) temporarily disable saucelabs because of flakiness (ampproject#20566) Fix closing the page attachment through popping the history state. (ampproject#20443) ✨Add AMP layer to E2E tests (ampproject#20502) add avenues for CLA help (ampproject#20521) provide more details on design reviews (ampproject#20533) 🗑️ Remove `video-dock` experiment guard. (ampproject#20413) ♻️ amp-recaptcha-input: Allow passing the recaptcha API url from the frame (ampproject#20539) 🐛 Fix amp-list documentation (ampproject#20553) launch amp-list-viewport-resize to 75% in prod (ampproject#20552)
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
To account for the entire poster image API surface and cases where placeholder is dynamically set, e.g. `amp-youtube`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To account for the entire
posterimage API surface and cases where placeholder is dynamically set, e.g.amp-youtube.