🐛Fix amp-inputmask attributes stripping in amp-mustache 0.2. #20515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
approved these changes
Jan 24, 2019
dreamofabear
requested changes
Jan 25, 2019
| 'value', | ||
| 'mask-output', | ||
| 'mask', | ||
| ], |
There was a problem hiding this comment.
value and mask should already be allowed: https://github.com/cure53/DOMPurify/blob/master/src/attrs.js
Try it out by adding a simple test case in test-purifier.js.
There was a problem hiding this comment.
mask looks like it's only allowed for svg, and this is for an input tag. I'll check the error messages to see what the issue with value was.
There was a problem hiding this comment.
DOMPurify doesn't use tag-specific whitelists for attributes. We should add a unit test for this change in test-purifier.js anyways.
dreamofabear
approved these changes
Jan 29, 2019
jsalgueiro
added a commit
to jsalgueiro/amphtml
that referenced
this pull request
Jan 29, 2019
* commit '39464270aa888000b7692e36f5b8eac302eab516': Enables layers in canary (ampproject#20512) 🏗 Show progress of `browserify` transform prior to running tests (ampproject#20573) 🐛Fix amp-inputmask attributes stripping in amp-mustache 0.2. (ampproject#20515) Clean up bindings after amp-list reset. (ampproject#20570) Fix amp-form server side rendering (ampproject#20511) 📖Add sidebar in stories documentation (ampproject#20385)
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…ect#20515) * Fix amp-inputmask attributes stripping in amp-mustache 0.2. Update example * Only add the new attribute mask-output * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update example
@choumx was there any reason why the purifier didn't already allow
value?