Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Add an rc-channel experiment ID to allow opt-in to the RC build of AMP #20223

Merged
merged 1 commit into from
Jan 9, 2019
Merged

🏗 Add an rc-channel experiment ID to allow opt-in to the RC build of AMP #20223

merged 1 commit into from
Jan 9, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 9, 2019

We now release 4 flavors of the AMP runtime:

  • Canary
    • Version prefix 00
    • Contains the latest code, and enables the experiments in canary-config.json
    • Served to 0.5% of all requests, and to those who opt in to the dev-channel experiment
  • Prod
    • Version prefix 01
    • Contains one-week-old code, and enables the experiments in prod-config.json
    • Currently served to 99% of all requests (soon to be 98.5%)
  • Control
    • Version prefix 02
    • Contains the same one-week-old code as Prod, and enables the experiments in prod-config.json
    • Served to 0.5% of all requests
    • Currently used to compare error rates with Canary (differences may be due to experiment config, or code, or both)
  • RC
    • Version prefix 03
    • Contains the latest code, and enables the experiments in prod-config.json
    • Currently served to 0% of all requests (soon to be 0.5%), and to those who opt in to the rc-channel experiment
    • Soon to be used to compare error rates with Canary (only difference being experiment config changes)
    • Soon to be used to compare error rates with Control (only difference being source code changes)

This PR adds the rc-channel experiment to the page served at https://cdn.ampproject.org/experiments.html

Fixes #17706

@rsimha
Copy link
Contributor Author

rsimha commented Jan 9, 2019

Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ampproject/tsc FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the ~1% canary is testing what gets rolled out to 100% during the release
3 participants