Try to fix integration tests flakiness #20062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
reviewed
Dec 21, 2018
testing/describes.js
Outdated
| this.spec.timeout = spec.timeout | ||
| || window.ampTestRuntimeConfig.mocha.integrationTimeout; | ||
| if (this.spec.retryOnSaucelabs === undefined) { | ||
| this.spec.retryOnSaucelabs = 3; |
There was a problem hiding this comment.
Shall we make it 4 to match the .retryOnSaucelabs()
lannka
force-pushed
the
retry-saucelabs
branch
from
9484bd6 to
9e6d3b9
Compare
zhouyx
approved these changes
Dec 22, 2018
cathyxz
reviewed
Dec 22, 2018
cathyxz
reviewed
Dec 22, 2018
lannka
force-pushed
the
retry-saucelabs
branch
from
3497a5c to
7db39ca
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* check in * add 50ms tolerance to timer interval * nit * Fix amp-fx-* tests * Longer timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20057