Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Stop printing a console error summary at the end of full test runs #19726

Merged
merged 1 commit into from
Dec 10, 2018
Merged

🏗 Stop printing a console error summary at the end of full test runs #19726

merged 1 commit into from
Dec 10, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Dec 7, 2018

This PR silences the long summary of console.error messages printed at the end of full unit and integration tests on Travis and during local development. It implements option 1 in #19654 (comment).

Note: Errors will still be printed when tests are run from an individual file with --files, or when tests are run via --local-changes. This is in keeping with the spirit of #7381.

Fixes #19654

@rsimha rsimha self-assigned this Dec 7, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Dec 7, 2018

/to @choumx

@rsimha rsimha merged commit 8bbe164 into ampproject:master Dec 10, 2018
@rsimha rsimha deleted the 2018-12-07-ConsoleErrorMessages branch December 10, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants