Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 gulp visual-diff refactor and stability fixes #19327

Merged
merged 9 commits into from
Nov 15, 2018
Merged

🏗 gulp visual-diff refactor and stability fixes #19327

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
199319d
Ensure that AMP was build with `--fortesting` when running visual dif…
Nov 14, 2018
561a229
Address text nit
Nov 14, 2018
7b770a6
Add visual diff file to whitelist of files allowed to use AMP_CONFIG …
Nov 15, 2018
a7f806d
Rewrite the log helper function to use appropriate streams, and throw…
Nov 15, 2018
e2048e0
Rename preVisualDiffTasks to ensureOrBuildAmpRuntimeInTestMode_ and c…
Nov 15, 2018
64eb0f1
Cleanup after an unhandled Promise rejection
Nov 15, 2018
6ba4de5
Cleanup should validate that the webServerProcess_ object exists befo…
Nov 15, 2018
37fdb2f
Refactor task into smaller functions
Nov 15, 2018
934917a
Add a workaround to the MaxListenersExceededWarning thrown by Node
Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup should validate that the webServerProcess_ object exists befo… 
…re checking if it was killed
  • Loading branch information
Daniel Rozenberg committed Nov 15, 2018
commit 6ba4de51a33d776c48542d513bedb3273a84451b
2 changes: 1 addition & 1 deletion build-system/tasks/visual-diff/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ async function cleanup_() {
if (browser_) {
await browser_.close();
}
if (!webServerProcess_.killed) {
if (webServerProcess_ && !webServerProcess_.killed) {
// Explicitly exit the webserver.
webServerProcess_.kill();
// The child node process has an asynchronous stdout. See #10409.
Expand Down