🏗 Remove --headless mode from gulp visual-diff task
#18510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Oct 2, 2018
contributing/TESTING.md
Outdated
| @@ -106,7 +106,6 @@ Command | Descri | |||
| `gulp todos:find-closed` | Find `TODO`s in code for issues that have been closed. | |||
| `gulp visual-diff` | Runs all visual diff tests on local Chrome. Requires `PERCY_PROJECT` and `PERCY_TOKEN` to be set as environment variables or passed to the task with `--percy_project` and `--percy_token`. | |||
There was a problem hiding this comment.
... on a headless instance of local Chrome
contributing/TESTING.md
Outdated
| @@ -255,11 +254,6 @@ Note that if you drop the `--nobuild` flag, `gulp visual-diff` will run `gulp bu | |||
|
|
|||
| The build will use the Percy credentials set via environment variables in the previous step, and run the tests on your local install of Chrome. You can see the results at `https://percy.io/<org>/<project>`. | |||
There was a problem hiding this comment.
... your local install of Chrome in headless mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-headless mode no longer works as expected with the introduction of parallelization in PR #17139, because all the tabs share the same viewport size in non-headless mode. If a specific test resizes its viewport, it affects other tests unexpectedly.