update with value/value_casei change #16858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregable
approved these changes
Jul 18, 2018
alin04
reviewed
Jul 18, 2018
| allowed_protocol: "https" | ||
| allowed_protocol: "http" | ||
| allow_relative: true | ||
| allow_empty: true |
There was a problem hiding this comment.
Are you alphabetizing these? empty should come before relative.
There was a problem hiding this comment.
No.
My preference that I've been enforcing because of OCD is that ordering for messages is based on order within validator.proto. Message values are alphabetized.
=D
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueandvalue_caseiare now repeated fields, this updates the examples and definitions to reflect this.