Code-cleanup of splittable fork. #16846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cramforce
commented
Jul 18, 2018
cramforce
commented
- Removes support for browser masking in NPM.
- Consolidates file patching in update-packages gulp task.
- Lots of other small stuff
- As a follow up to Clean up incosistent hack to patch document-register-element. #16837 switch document-register-element to not use a default export from CommonJS, because this confuses our build system across babel, browserify, closure, etc.
cramforce
force-pushed
the
cleanup-splittable
branch
from
683df6e to
6e762bb
Compare
- Removes support for browser masking in NPM. - Simplify code based on lack of base module separate from main. - Consolidates file patching in update-packages gulp task. - Lots of other small stuff - As a follow up to ampproject#16837 switch document-register-element to not use a default export from CommonJS, because this confuses our build system across babel, browserify, closure, etc.
cramforce
force-pushed
the
cleanup-splittable
branch
from
6e762bb to
774c85b
Compare
Codecov Report
@@ Coverage Diff @@
## master #16846 +/- ##
==========================================
+ Coverage 78.13% 78.14% +0.01%
==========================================
Files 560 560
Lines 40565 40565
==========================================
+ Hits 31696 31701 +5
+ Misses 8869 8864 -5
Continue to review full report at Codecov.
|
erwinmombay
approved these changes
Jul 18, 2018
|
Part of #16847 |
cramforce
added a commit
that referenced
this pull request
Jul 18, 2018
This reverts commit 6470c1e.
This was referenced Jul 18, 2018
cramforce
added a commit
that referenced
this pull request
Jul 18, 2018
- Removes support for browser masking in NPM. - Consolidates file patching in update-packages gulp task. - Lots of other small stuff - As a follow up to #16837 switch document-register-element to not use a default export from CommonJS, because this confuses our build system across babel, browserify, closure, etc. Roll forward of #16846 The revert was a red herring. The real problem was caused by the Travis cache.
|
Part of #16847 |
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
- Removes support for browser masking in NPM. - Simplify code based on lack of base module separate from main. - Consolidates file patching in update-packages gulp task. - Lots of other small stuff - As a follow up to ampproject#16837 switch document-register-element to not use a default export from CommonJS, because this confuses our build system across babel, browserify, closure, etc.
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
- Removes support for browser masking in NPM. - Consolidates file patching in update-packages gulp task. - Lots of other small stuff - As a follow up to ampproject#16837 switch document-register-element to not use a default export from CommonJS, because this confuses our build system across babel, browserify, closure, etc. Roll forward of ampproject#16846 The revert was a red herring. The real problem was caused by the Travis cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.