Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-list: Reset when refreshing with local data #16843

Merged
merged 4 commits into from
Jul 19, 2018
Merged

amp-list: Reset when refreshing with local data #16843

merged 4 commits into from
Jul 19, 2018

Conversation

dreamofabear
Copy link

@dreamofabear dreamofabear commented Jul 18, 2018 •
edited
Loading

Fixes #16840.

/to @cathyxz

@dreamofabear dreamofabear requested review from aghassemi and nainar and removed request for aghassemi July 18, 2018 05:14
@aghassemi aghassemi requested review from cathyxz and removed request for nainar July 18, 2018 17:17
@aghassemi
Copy link
Contributor

/cc @cathyxz since she is taking ownership of amp-list

@dreamofabear dreamofabear removed the request for review from aghassemi July 19, 2018 18:08
@dreamofabear dreamofabear merged commit 0ee6221 into ampproject:master Jul 19, 2018
@dreamofabear dreamofabear deleted the amp-list-reset-mutate branch July 19, 2018 18:15
@aghassemi aghassemi mentioned this pull request Jul 30, 2018
Closed
@dreamofabear dreamofabear mentioned this pull request Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathyxz cathyxz cathyxz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamofabear @aghassemi @cathyxz @googlebot