Fix amp-image won't render after resize in amp-fx-flying-carpet with media attribute #16809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16809 +/- ##
==========================================
- Coverage 78.09% 78.02% -0.08%
==========================================
Files 558 558
Lines 40437 40438 +1
==========================================
- Hits 31578 31550 -28
- Misses 8859 8888 +29
Continue to review full report at Codecov.
|
jridgewell
reviewed
Jul 17, 2018
| setStyle(this.container_, 'width', width, 'px'); | ||
| }); | ||
| this.scheduleLayout(dev().assertElement(this.container_)); |
There was a problem hiding this comment.
This needs to be reverted. It can only schedule layout for the container if it itself has been laid out.
There was a problem hiding this comment.
Can onMeasureChanged get called before layout?
There was a problem hiding this comment.
It can be called after build.
There was a problem hiding this comment.
Revert PR: #16816
This was referenced Jul 17, 2018
Revert "Fix amp-image won't render after resize in amp-fx-flying-carpet with media attribute"
#16816
Closed
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
…media attribute (ampproject#16809) * Add flying carpet media test * Schedule layout of flying carpet container on onMeasureChanged * Add unit test * Assert element tand force non null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11621