Extract config logic to a separate file from amp-analytics.js #16805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
approved these changes
Jul 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #16805 +/- ##
==========================================
- Coverage 78.07% 78.01% -0.06%
==========================================
Files 558 559 +1
Lines 40439 40456 +17
==========================================
- Hits 31571 31560 -11
- Misses 8868 8896 +28
Continue to review full report at Codecov.
|
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
…ject#16805) * Extract config logic to a separate file from amp-analytics.js * Fix presubmit checks. * Fix presubmit checks. * toWin * lint fix * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #15608