Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Mark the <amp-jwplayer> visual diff test as flaky #16766

Merged
merged 1 commit into from
Jul 16, 2018
Merged

✅ Mark the <amp-jwplayer> visual diff test as flaky #16766

merged 1 commit into from
Jul 16, 2018

Conversation

danielrozenberg
Copy link
Member

Fixed #16764

@danielrozenberg danielrozenberg requested a review from rsimha July 16, 2018 22:28
rsimha
rsimha approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: do we have a fix in mind (say, by adding a mechanism to wait long enough)?

@danielrozenberg
Copy link
Member Author

I'm planning on taking a look at deflaking these tests next week

@danielrozenberg danielrozenberg merged commit a7ed850 into ampproject:master Jul 16, 2018
@danielrozenberg danielrozenberg deleted the visual-diff-flake branch July 16, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielrozenberg @rsimha @googlebot