Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action trust error message #16600

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

dreamofabear
Copy link

@dreamofabear dreamofabear commented Jul 6, 2018

Before:

Insufficient trust for "setState" (1 < 100).

After:

"timeout" is not allowed to invoke "AMP.setState".

Context: #16567

Also fix a bunch of broken action tests due to allowConsoleError.

@codecov-io
Copy link

Codecov Report

Merging #16600 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16600      +/-   ##
==========================================
+ Coverage   78.07%   78.08%   +0.01%     
==========================================
  Files         553      553              
  Lines       40320    40321       +1     
==========================================
+ Hits        31478    31484       +6     
+ Misses       8842     8837       -5
Flag Coverage Δ
#integration_tests 34.92% <50%> (ø) ⬆️
#unit_tests 77.15% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0d686...0b2d321. Read the comment docs.

@dreamofabear dreamofabear merged commit f4928df into ampproject:master Jul 10, 2018
@dreamofabear dreamofabear deleted the better-trust-error branch July 10, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants