Validator Roll-up #1643
Merged
Validator Roll-up #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we use an enum for the TokenType, so the Javascript is more strongly typed than previously (it was just a string).
Also, fix some lint errors.
#1600 The one change in the tests is another example that we probably need to do something with the dispatch_key for better fallback error messages.
The check for also_requires was not working properly and now is Tagspecs must have a detail if there are multiple tagspecs for the same tag Added detail to tagspecs that have the same tag Update testdata to reflect these changes
See #1607 I copied over from amp-ad, then edited name and comment. Also placed a hint that they should be changed together.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@googlebot I confirm. |
|
@googlebot I confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS Parser refactorings.
Fix enforcement of also_requires feature for requiring javascript matching amp tags.
Fix a bug where we were misusing a Map() like object.
Add amp-embed.