Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a line to cherry picks doc letting requesters know it is a lot of work #16148

Merged
merged 1 commit into from
Jun 19, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion contributing/release-schedule.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ We have a well-defined process for handling requests for changes to the canary r

### Cherry pick criteria

**The bar for getting a cherry pick into canary or production is very high** because our goal is to produce high quality launches on a predictable schedule:
**The bar for getting a cherry pick into canary or production is very high** because our goal is to produce high quality launches on a predictable schedule.

**Keep in mind that performing a cherry pick requires a significant amount of work from you and the onduty person** and they can take a long time to process.

- In general only fixes for [P0 issues](https://github.com/ampproject/amphtml/blob/master/contributing/issue-priorities.md) (causing "an outage or a critical production issue") may be cherry picked. P0 issues are those that:
- cause privacy or security issues
- cause user data loss
Expand Down