Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amp-story examples with v1 requirements #16093

Merged
merged 2 commits into from
Jul 1, 2018

Conversation

sanjsanj
Copy link
Contributor

After the changes to the amp-story v1 bookend many of the amp-story examples are out of date and do not display a bookend.

This PR is to fix that and remove reference to v0.1 way of setting the bookend.

Attn: @newmuis

@aghassemi aghassemi requested a review from newmuis June 20, 2018 23:59
Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@sanjsanj
Copy link
Contributor Author

sanjsanj commented Jul 1, 2018

@newmuis Just reminding you this is still here 😄
Let me know if you want changes.

@newmuis
Copy link
Contributor

newmuis commented Jul 1, 2018

Whoooooops

Thanks for the reminder 🙂

@newmuis newmuis merged commit f49f3cb into ampproject:master Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants