Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize page load time on mobile #1606

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Conversation

cramforce
Copy link
Member

  • don't allocate an a tag per URL parse
  • delay preconnect during build phase a bit. This is kind of a bummer, but it really slims down the initial JS execution.

- don't allocate an a tag per URL parse
- delay preconnect during build phase a bit. This is kind of a bummer, but it really slims down the initial JS execution.
@@ -24,7 +25,6 @@ import {assert} from './asserts';
* @return {!Location}
*/
export function parseUrl(url) {
const a = document.createElement('a');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jridgewell
Copy link
Contributor

LGTM

cramforce added a commit that referenced this pull request Jan 27, 2016
Optimize page load time on mobile
@cramforce cramforce merged commit 93b9726 into ampproject:master Jan 27, 2016
@cramforce cramforce deleted the preconnect branch January 27, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants