get rid of newline from sha #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
get-rid-of-newline-from-sha
branch
from
a7ad96a
to
b7d0e77
Compare
| @@ -112,7 +112,9 @@ function submitReleaseNotes(version, changelog, sha) { | |||
| } | |||
|
|
|||
| function getCurrentSha() { | |||
| return gitExec({ args: 'rev-parse HEAD' }); | |||
| return gitExec({ args: 'rev-parse HEAD' }).then(function(sha) { | |||
| return sha.replace(/\n/, ''); | |||
There was a problem hiding this comment.
String#trim will trim whitespace for you.
erwinmombay
force-pushed
the
get-rid-of-newline-from-sha
branch
from
b7d0e77
to
5236b24
Compare
|
LGTM |
erwinmombay
added a commit
that referenced
this pull request
Jan 26, 2016
get rid of newline from sha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.