Fixes for history state due to nesting of services #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko LGTM |
| const replaceStateSpy = sinon.spy(); | ||
| const windowStub = { | ||
| history: { | ||
| replaceState: function() { |
There was a problem hiding this comment.
You can just use replaceState: replaceStateSpy
There was a problem hiding this comment.
Can't. Because it gets monkey-patched.
There was a problem hiding this comment.
Actually, no, I'm wrong. This is a good point. Fixed.
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Jan 26, 2016
Fixes for history state due to nesting of services
This was referenced Dec 30, 2021
This was referenced Feb 7, 2022
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1237.