Moving the amp-story-consent JSON configuration. #15473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
suggested changes
May 21, 2018
| this.actions_.addToWhitelist('AMP-CONSENT.accept'); | ||
| this.actions_.addToWhitelist('AMP-CONSENT.reject'); | ||
| // Story consent config is set by the `assertAndParseConfig_` method. | ||
| if (this.storyConsentConfig_) { |
Contributor
There was a problem hiding this comment.
nit: since you checked with user().assert() I don't think this is necessary.
Contributor
There was a problem hiding this comment.
talked offline. did this to pass linter check.
@gmajoulet You may want to add details here : )
Contributor
Author
There was a problem hiding this comment.
For some reason the linter didn't accept a user().assert or a /** @type {!Object} (...) */...
| const script = childElementByTag(parentEl, 'script'); | ||
| this.consentConfig_ = parseJson(script.textContent); | ||
| const consentScript = childElementByTag(parentEl, 'script'); | ||
| this.consentConfig_ = parseJson(consentScript.textContent); |
zhouyx
approved these changes
May 22, 2018
Contributor
zhouyx
left a comment
zhouyx
left a comment
There was a problem hiding this comment.
lgtm. Thanks for the change!
dreamofabear
approved these changes
May 22, 2018
gmajoulet
force-pushed
the
gdpr_consent_moving_json_config
branch
from
9dead8c to
41afdbe
Compare
calebcordry
pushed a commit
that referenced
this pull request
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the amp-story-consent JSON configuration.
Context: https://github.com/ampproject/amphtml/pull/15366/files/f48b29ca4203dd4cfce001b9555128d307551c7b#r189401119
Part of #14538