Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad API to unobserve intersections from 3p frame #1536

Merged
merged 1 commit into from
Jan 24, 2016
Merged

Ad API to unobserve intersections from 3p frame #1536

merged 1 commit into from
Jan 24, 2016

Conversation

camelburrito
Copy link
Contributor

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 5c65a2c2ae28d87d9d33a8ba9c3e7714e0d06418
Build details: https://travis-ci.org/ampsauce/amphtml/builds/104198976

(Please note that this is a fully automated comment.)

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: ffc469b3eef67bbd73d8f523051e6a9463a3d920
Build details: https://travis-ci.org/ampsauce/amphtml/builds/104199428

(Please note that this is a fully automated comment.)

cramforce
cramforce reviewed Jan 23, 2016
View reviewed changes
3p/integration.js
@@ -166,11 +166,11 @@ function nonSensitiveDataPostMessage(type, opt_object) {
* the IntersectionObserver spec callback.
* http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html#callbackdef-intersectionobservercallback
* @param {function(!Array<IntersectionObserverEntry>)} observerCallback
* @returns {!function} A functions which removes the event listener that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: function singular

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@cramforce
Copy link
Member

Document in ads/README.md

Done

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a6dc0dba3aa924505b3a687c60551ebfed3c6f4b
Build details: https://travis-ci.org/ampsauce/amphtml/builds/104219973

(Please note that this is a fully automated comment.)

@camelburrito
Copy link
Contributor Author

PTAL

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: cc251de
Build details: https://travis-ci.org/ampsauce/amphtml/builds/104223832

(Please note that this is a fully automated comment.)

@cramforce
Copy link
Member

LGTM

camelburrito pushed a commit that referenced this pull request Jan 24, 2016
Merge pull request #1536 from sriramkrish85/intersection
f35212d 
Ad API to unobserve intersections from 3p frame
@camelburrito camelburrito merged commit f35212d into ampproject:master Jan 24, 2016
@elijahsoria elijahsoria mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramforce cramforce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camelburrito @ampsauce @cramforce