-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ad API to unobserve intersections from 3p frame #1536
Conversation
5c65a2c
to
ffc469b
Compare
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 5c65a2c2ae28d87d9d33a8ba9c3e7714e0d06418 (Please note that this is a fully automated comment.) |
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: ffc469b3eef67bbd73d8f523051e6a9463a3d920 (Please note that this is a fully automated comment.) |
@@ -166,11 +166,11 @@ function nonSensitiveDataPostMessage(type, opt_object) { | |||
* the IntersectionObserver spec callback. | |||
* http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html#callbackdef-intersectionobservercallback | |||
* @param {function(!Array<IntersectionObserverEntry>)} observerCallback | |||
* @returns {!function} A functions which removes the event listener that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: function singular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Document in Done |
ffc469b
to
a6dc0db
Compare
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: a6dc0dba3aa924505b3a687c60551ebfed3c6f4b (Please note that this is a fully automated comment.) |
a6dc0db
to
cc251de
Compare
PTAL |
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: cc251de (Please note that this is a fully automated comment.) |
LGTM |
Ad API to unobserve intersections from 3p frame
#1340