Add instrumentation to embed iframe #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const setInterval = win.setInterval; | ||
| const intervals = {}; | ||
| let intervalId = 0; | ||
| win.setInterval = function(fn, time) { |
There was a problem hiding this comment.
What's the point in overriding this?
There was a problem hiding this comment.
Happy to chat offline about reasons.
cramforce
force-pushed
the
ads-intervention
branch
2 times, most recently
from
39db54a
to
6768275
Compare
| parent.ampManageWin = function(win) { | ||
| manageWin(win); | ||
| }; | ||
| html = html |
cramforce
force-pushed
the
ads-intervention
branch
3 times, most recently
from
855c9d3
to
5481383
Compare
|
This is now ready for review. |
cramforce
force-pushed
the
ads-intervention
branch
from
5481383
to
3b1ef85
Compare
| * @type {{inViewport: true}} | ||
| * @visibleForTesting | ||
| */ | ||
| export const docState = { |
There was a problem hiding this comment.
How about a module variable here, with a setter method for testing.
cramforce
force-pushed
the
ads-intervention
branch
2 times, most recently
from
751934a
to
52190f3
Compare
|
PTAL |
| */ | ||
| export function getDocStateForTesting() { | ||
| return docState; | ||
| } |
There was a problem hiding this comment.
With a setter, there's no longer a need for a docState object.
let inViewport = true;
export function setViewportForTesting(value) {
inViewport = value
}
|
LGTM from me. |
cramforce
force-pushed
the
ads-intervention
branch
from
52190f3
to
0c69426
Compare
cramforce
force-pushed
the
ads-intervention
branch
from
0c69426
to
f0e961b
Compare
|
|
cramforce
added a commit
that referenced
this pull request
Jan 26, 2016
Add instrumentation to embed iframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.