✅ Fail tests that call console error when they are run during local dev
#15043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @danielrozenberg @erwinmombay |
|
You should differentiate between running |
|
@danielrozenberg Good idea. Done. |
danielrozenberg
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14406 is tracking the effort to fix AMP tests that result in unexpected calls to
console.error. For the past month, tests would warn on unexpected errors, but continue to pass. Now it's time to start failing tests during local development, so that these errors are fixed.Tests will continue to pass on Travis and when
gulp pr-checkis run locally.Related to #14406