Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator sync #14714

Merged
merged 10 commits into from
Apr 18, 2018
Merged

Validator sync #14714

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77e3129
Revision bump for #14192
Apr 18, 2018
96a42ab
Revision bump for #14564
Apr 18, 2018
a334faa
./build.py --update_tests for validator tests
powdercloud Apr 18, 2018
be288eb
Lightbox carousel validator rules.
Apr 18, 2018
ddb313a
Revision bump for #14571,#14582
Apr 18, 2018
8794aff
Change application/json tag attribute to 'type' in amp-next-page.
Apr 18, 2018
16ffaf7
better svg parsing support
powdercloud Apr 18, 2018
3423cd1
Sync amp-story test files.
Apr 18, 2018
ecb90a2
Revision Bump.
Apr 18, 2018
bafed8a
allow usage of console.log for updating test file messages
honeybadgerdontcare Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change application/json tag attribute to 'type' in amp-next-page.
  • Loading branch information
@honeybadgerdontcare
Greg Grothaus authored and honeybadgerdontcare committed Apr 18, 2018
commit 8794affd404b0c4b074dbd69593e0da50917b343
2 changes: 1 addition & 1 deletion extensions/amp-next-page/validator-amp-next-page.protoascii
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ tags: { # amp-next-page: json config
requires_extension: "amp-next-page"
mandatory_parent: "AMP-NEXT-PAGE"
attrs: {
name: "pages"
name: "type"
mandatory: true
value_casei: "application/json"
dispatch_key: NAME_VALUE_PARENT_DISPATCH
Expand Down
2 changes: 1 addition & 1 deletion validator/validator-main.protoascii
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ min_validator_revision_required: 322
# newer versions of the spec file. This is currently a Google internal
# mechanism, validator.js does not use this facility. However, any
# change to this file (validator-main.js) requires updating this revision id.
spec_file_revision: 608
spec_file_revision: 609

styles_spec_url: "https://www.ampproject.org/docs/guides/author-develop/responsive/style_pages"
script_spec_url: "https://www.ampproject.org/docs/reference/spec#html-tags"
Expand Down