Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows the build script of the validator to execute both 'node' or 'nodejs' command #1467

Conversation

neveldo
Copy link
Contributor

@neveldo neveldo commented Jan 18, 2016

In the comments from the PR #1440 , it appears that the build script should work with node or nodejs command available on the system (ubuntu indeed makes available Node.js through the nodejs command).

Maybe, some code factorisation could be done in the getNodeJsCmd() function ?

@powdercloud
Copy link
Contributor

Thanks a ton, this looks great!

powdercloud added a commit that referenced this pull request Jan 19, 2016
…-be-run-from-node-or-nodejs-cmd

Allows the build script of the validator to execute both 'node' or 'nodejs' command
@powdercloud powdercloud merged commit 17f600b into ampproject:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants